Comments on: Ajax with ASP.NET MVC Framework Preview 2

By: Emad Ibrahim

Emad Ibrahim — Tue, 27 May 2008 13:13:39 +0000

@Pieter: thanks for sharing your findings
@Christian: I am not sure what is going on here. I personally never used ContainsDataItem method on ViewData because I always used a typed ViewData.

I have a BaseViewData that is used on the master page and every page using that master and then I create derived classes for ViewData for each page e.g. UserInfoViewData, etc…

By: Christian Schiffer

Christian Schiffer — Tue, 27 May 2008 11:27:15 +0000

Thanks for the update, also thank to Pieter, but I still have problems with the RenderPartialCore method, like Pieter says when calling the RenderPartial method on a UserControl it becomes a recursive call and we get an overflow exception, after having chnged the methos to Pieters version that doesent happen anymore, however somehow my Viewdata get corrupted so that even though it looks the same when examining it in debud I cannot access the data i the ViewData. eg. calling the ViewData.ContainsDataItem(MyKey) returns false even though examing the object clearly show the existence of the Key and Data.

Any thoughts? Updates? I am using preview 2 the interim release. Please answer quickly I am so stuck…

By: Emad Ibrahim

Emad Ibrahim — Tue, 27 May 2008 11:13:39 +0000

@Pieter: thanks for sharing your findings
@Christian: I am not sure what is going on here. I personally never used ContainsDataItem method on ViewData because I always used a typed ViewData.

I have a BaseViewData that is used on the master page and every page using that master and then I create derived classes for ViewData for each page e.g. UserInfoViewData, etc…

By: Christian Schiffer

Christian Schiffer — Tue, 27 May 2008 09:27:15 +0000

Any thoughts? Updates? I am using preview 2 the interim release. Please answer quickly I am so stuck…

By: Pieter

Pieter — Tue, 13 May 2008 20:36:12 +0000

Thanks for the patch. Just noticed something a bit strange. In the AjaxViewExtensions class your change results in a recursive call to the calling View (if that makes sense).

Thus if you try the following (List.aspx):
this.RenderPartial("UserList", ViewData.Users);

where UserList is a UserControl (ascx), the RenderPartial calls List.aspx again.

To fix this I changed the RenderPartialCore method to:
private static void RenderPartialCore(ViewContext viewContext, string viewName, object viewData) { if (String.IsNullOrEmpty(viewName)) throw new ArgumentNullException(viewName);


            // TODO: Need to be able to get the view engine associated with this controller

            //       without the cast to the specific implementation

            Controller controller = (Controller)viewContext.Controller;
            // create a new view context for the view called, not the existing view

            ViewContext newContext = new ViewContext(controller.ControllerContext, viewName, null, viewData, controller.TempData);

//emad ibrahim: controller has a viewengine already controller.ViewEngine.RenderView(newContext); //IViewFactory viewFactory = controller.ViewFactory; //IView partialView = viewFactory.CreateView(viewContext, viewName, null, viewData); //partialView.RenderView(viewContext); }

By: Pieter

Pieter — Tue, 13 May 2008 18:36:12 +0000

Thanks for the patch. Just noticed something a bit strange. In the AjaxViewExtensions class your change results in a recursive call to the calling View (if that makes sense).

Thus if you try the following (List.aspx):


this.RenderPartial("UserList", ViewData.Users);

where UserList is a UserControl (ascx), the RenderPartial calls List.aspx again.

To fix this I changed the RenderPartialCore method to:


        private static void RenderPartialCore(ViewContext viewContext, string viewName, object viewData)
        {
            if (String.IsNullOrEmpty(viewName))
                throw new ArgumentNullException(viewName);

            // TODO: Need to be able to get the view engine associated with this controller
            //       without the cast to the specific implementation
            Controller controller = (Controller)viewContext.Controller;

            // create a new view context for the view called, not the existing view
            ViewContext newContext = new ViewContext(controller.ControllerContext, viewName, null, viewData, controller.TempData);

            //emad ibrahim: controller has a viewengine already
            controller.ViewEngine.RenderView(newContext);
            //IViewFactory viewFactory = controller.ViewFactory;
            //IView partialView = viewFactory.CreateView(viewContext, viewName, null, viewData);
            //partialView.RenderView(viewContext);
        }

By: Henry

Henry — Mon, 07 Apr 2008 13:52:25 +0000

Thank you so very much.

By: Henry

Henry — Mon, 07 Apr 2008 11:52:25 +0000

Thank you so very much.